Bit of a headache

[Jansolo]

Hi all,

I have found this bit of javascript to validate a users form input, but the
problem is that it does it in steps - ie it will check the name and if that
isn't present it will stop the form and display just the name error.

However I want it to display all the errors in one go (so if the name AND the
email is left blank, it will display both errors at the same time!). I am sure
it has to do with where you place the return false value but after an hour of
mucking about I just don't seem to be able to get it to work.

Here is the script:

function checkForm() {
name = document.getElementById("name").value;
email = document.getElementById("email").value;
comment = document.getElementById("comment").value;

if (name == "") {
hideAllErrors();
document.getElementById("nameError").style.display = "inline";
document.getElementById("name").select();
document.getElementById("name").focus();
return false;
} else if (email == "") {
hideAllErrors();
document.getElementById("emailError").style.displa y = "inline";
document.getElementById("email").select();
document.getElementById("email").focus();
return false;
} else if (comment == "") {
hideAllErrors();
document.getElementById("commentError").style.disp lay = "inline";
document.getElementById("comment").select();
document.getElementById("comment").focus();
return false;
}
return true;
}

function hideAllErrors() {
document.getElementById("nameError").style.display = "none"
document.getElementById("emailError").style.displa y = "none"
document.getElementById("commentError").style.disp lay = "none"
}

[Deaf Web Designer]

can you also post a example page, where we can take a look at js and html work together. it is important that you also show us html source page, just point us to your URL address and we go from there.

[Jansolo]

Hi there,

The URL is:

[url]http://www.names4design.co.uk/test.htm[/url]

[delaneypub]

In your checkForm function, your use of "else if" will bypass any of the checks
below tonce any of them is true. If name == "" is true, then it won't even
check email and comment. Replace the "else if"s with if. Also, "return" will
cause processing of the function to stop the first time it's encountered. So,
you need to set a flag if any of the checks find an error, and then only
"return false" at the very end if there are errors, else "return true"

[Deaf Web Designer]

I think you need to add a ';' (one of each) in the following script code as
follows below:

Your code as shown earlier:
From here:
document.getElementById("nameError").style.display = "none"
document.getElementById("emailError").style.displa y = "none"
document.getElementById("commentError").style.disp lay = "none"

To here:
document.getElementById("nameError").style.display = "none";
document.getElementById("emailError").style.displa y = "none";
document.getElementById("commentError").style.disp lay = "none";

I will take a look at Elaine's quick advice. Let us know if that works with
';' at end of those three codes.

Thanks in advance, DWD