Checking my code

[David P. Jessup]

Good day folks.

I am currently working on taking messages from my router and trying to parse
the log. I have done this, but want some feedback to see if I have done
this with the mininmal amount of code, or the best method of writing it in
your opinions.

Code follows:

Dim Text,PT,PTT,tSIPp,Last
RawText = "Hacker Log[26782]:PROTO_TCP, SIP:24.242.49.56: 2722,
DIP:24.242.178.122: 80, Code-Red"
Text = split(RawText,":",-1,1)
PT=split(Text(1),",",2,1)
PTT=split(PT(0),"_",2,1)
PType= PTT(1)
SIP=Text(2)
tSIPp = split(Text(3),",",2,1)
SIPp=tSIPp(0)
DIP=Text(4)
last = split(Text(5),",",2,1)
DIPp=Last(0)
AtkName=Last(1)

Response.Write "Protocol Type: " & PType & "<br>"
Response.Write "Source IP: " & SIP & "<br>"
Response.Write "Source IP Port: " & SIPp & "<br>"
Response.Write "Destination IP: " & DIP & "<br>"
Response.Write "Destination IP Port: " & DIPp & "<br>"
Response.Write "Attack Name: " & AtkName & "<br>"

Thanks from this ASP Newbie

[Ray at]

I think it's fine. All code can be written in many different ways, so it
all depends on what you like. I don't see anything glaringly inefficient or
"wrong" anywhere. What I would do differently is the naming conventions of
variables.

sText, sPT, sPTT, sSIPp, sLast

If you want to get as few lines as possible, you could start doing
substitution method with your code to eliminate lines (which typically has
an adverse effect on readability). Example:



Replace:
last = split(Text(5),",",2,1)
DIPp=Last(0)

With:
DIPp = split(Text(5),",",2,1)(0)

But I'm only throwing that in for the sake of finding something to change.

Ray at work



"David P. Jessup" <davidATimntDASHtechDOTcom> wrote in message
news:ut1KzQ6dDHA.3820@tk2msftngp13.phx.gbl...

> Good day folks.
>
> I am currently working on taking messages from my router and trying to

parse

> the log. I have done this, but want some feedback to see if I have done
> this with the mininmal amount of code, or the best method of writing it in
> your opinions.
>
> Code follows:
>
> Dim Text,PT,PTT,tSIPp,Last
> RawText = "Hacker Log[26782]:PROTO_TCP, SIP:24.242.49.56: 2722,
> DIP:24.242.178.122: 80, Code-Red"
> Text = split(RawText,":",-1,1)
> PT=split(Text(1),",",2,1)
> PTT=split(PT(0),"_",2,1)
> PType= PTT(1)
> SIP=Text(2)
> tSIPp = split(Text(3),",",2,1)
> SIPp=tSIPp(0)
> DIP=Text(4)
> last = split(Text(5),",",2,1)
> DIPp=Last(0)
> AtkName=Last(1)
>
> Response.Write "Protocol Type: " & PType & "<br>"
> Response.Write "Source IP: " & SIP & "<br>"
> Response.Write "Source IP Port: " & SIPp & "<br>"
> Response.Write "Destination IP: " & DIP & "<br>"
> Response.Write "Destination IP Port: " & DIPp & "<br>"
> Response.Write "Attack Name: " & AtkName & "<br>"
>
> Thanks from this ASP Newbie
>
>

[David P. Jessup]

Thanks Ray for quick response!

[Jeff Cochran]

Assuming the fields are always split on those delimiters, and that you
won't see any additional fields tossed in among them in the log, your
code appears fine.

Jeff

On Wed, 10 Sep 2003 09:02:36 -0500, "David P. Jessup"
<davidATimntDASHtechDOTcom> wrote:

>Good day folks.
>
>I am currently working on taking messages from my router and trying to parse
>the log. I have done this, but want some feedback to see if I have done
>this with the mininmal amount of code, or the best method of writing it in
>your opinions.
>
>Code follows:
>
>Dim Text,PT,PTT,tSIPp,Last
>RawText = "Hacker Log[26782]:PROTO_TCP, SIP:24.242.49.56: 2722,
>DIP:24.242.178.122: 80, Code-Red"
>Text = split(RawText,":",-1,1)
>PT=split(Text(1),",",2,1)
>PTT=split(PT(0),"_",2,1)
>PType= PTT(1)
>SIP=Text(2)
>tSIPp = split(Text(3),",",2,1)
>SIPp=tSIPp(0)
>DIP=Text(4)
>last = split(Text(5),",",2,1)
>DIPp=Last(0)
>AtkName=Last(1)
>
>Response.Write "Protocol Type: " & PType & "<br>"
>Response.Write "Source IP: " & SIP & "<br>"
>Response.Write "Source IP Port: " & SIPp & "<br>"
>Response.Write "Destination IP: " & DIP & "<br>"
>Response.Write "Destination IP Port: " & DIPp & "<br>"
>Response.Write "Attack Name: " & AtkName & "<br>"
>
>Thanks from this ASP Newbie
>