desperate: need help with updating recods

mike @ Syntrack · mike @ Syntrack

Hi, I'm sending this info:

[url]http://step/update_SIM_admin.asp?project=retrtertert&employee= mike%3F%3F&dat[/url]
e_start=&date_end=&updateQry=+&state=in+use&SIM_ID =8931440000305551182%2C+89
31440000305551190%2C+8931440000305551208%2C+893144 0000305551224%2C+893144000
0305551232%2C+8931440000305551240%2C+8931440000305 551257&submit=update+regis
tration

to the asp file undermeath. But when it goes trough the loop for the second
time, it says:
8931440000305551182

SELECT * from SIMS where SIM_ID = '8931440000305551182'

8931440000305551190

SELECT * from SIMS where SIM_ID = ' 8931440000305551190'

ADODB.Recordset error '800a0bcd'

Either BOF or EOF is True, or the current record has been deleted. Requested
operation requires a current record.

/update_SIM_admin.asp, line 29

************************************
************************************
This is my code:

<html>

<body>

<%

Dim SIM_ID_ARRAY
SIM_ID_array = Split(request("SIM_ID"),",")

dim sql, teller, rs, connection

teller = 0
while not teller = Ubound(SIM_ID_array) + 1

Set connection = Server.CreateObject( "ADODB.Connection" )
connection.open "DSN=SIMS.mdb"

Set rs = Server.CreateObject( "ADODB.RecordSet" )

%> <%
response.write(SIM_ID_array(teller))
sql = "SELECT * from SIMS where SIM_ID = '" & SIM_ID_array(teller) & "'"
%> <%
response.write(sql)

Set rs = Server.CreateObject( "ADODB.RecordSet" )
rs.Open sql, connection, 2, 2

rs("syntrack_project") = request("project")
rs.Update

teller = teller + 1

rs.close
set rs = nothing

connection.close
set connection = nothing

set sql = nothing
Wend

'Response.Redirect "sims.htm"

%> 

</body>
</html>

Ray at · Ray at

"mike @ Syntrack" <mike.van.der.hulst@noooospam.syntrack.nl> wrote in
message news:3f8e7012$0$256$4d4ebb8e@read.news.nl.uu.net.. .

>

[url]http://step/update_SIM_admin.asp?project=retrtertert&employee= mike%3F%3F&dat[/url]

>

e_start=&date_end=&updateQry=+&state=in+use&SIM_ID =8931440000305551182%2C+89

>

31440000305551190%2C+8931440000305551208%2C+893144 0000305551224%2C+893144000

>

0305551232%2C+8931440000305551240%2C+8931440000305 551257&submit=update+regis

> tration

I think it may be time to consider moving to method=post.

>
> to the asp file undermeath. But when it goes trough the loop for the

second

> time, it says:
> 8931440000305551182
>
> SELECT * from SIMS where SIM_ID = '8931440000305551182'

Please read this after you have the other issues worked out and consider it.
[url]http://www.aspfaq.com/2096[/url]

> Either BOF or EOF is True, or the current record has been deleted.

Requested

> operation requires a current record.

I guess that would be because there are no records returned in your query.
See additional inline replies.

> <%
>
> Dim SIM_ID_ARRAY
> SIM_ID_array = Split(request("SIM_ID"),",")

Request what? Request.cookies? Don't just use Request("item"). Always
specify what collection you want to pull from, i.e. querystring, form,
cookies, servervariables, Clientcertificate

> dim sql, teller, rs, connection
>
> teller = 0
> while not teller = Ubound(SIM_ID_array) + 1
>
> Set connection = Server.CreateObject( "ADODB.Connection" )

You may want to put this connection outside of your while/wend loop so
you're not creating and destroying it over and over.

> connection.open "DSN=SIMS.mdb"

Instead of using a dsn, you should use an oledb connection string from
[url]www.connectionstrings.com[/url]

>
> Set rs = Server.CreateObject( "ADODB.RecordSet" )

This line isn't necessary.

>
> %> <%
> response.write(SIM_ID_array(teller))
> sql = "SELECT * from SIMS where SIM_ID = '" & SIM_ID_array(teller) & "'"
> %> <%
> response.write(sql)

Nice!!!

> Set rs = Server.CreateObject( "ADODB.RecordSet" )

Doesn't this already exist?

> rs.Open sql, connection, 2, 2
>
> rs("syntrack_project") = request("project")
> rs.Update

Instead of creating a recordset and updating it, why not just execute an
INSERT command?

sql = "UPDATE [SIMS] SET [syntrack_project]='" &
Replace(Request.Querystring("project"), "'", "''") & "'"
connection.Execute sql

>
> teller = teller + 1
>
> rs.close
> set rs = nothing
>
> connection.close
> set connection = nothing
>
> set sql = nothing
> Wend

Ray at work

Aaron Bertrand - MVP · Aaron Bertrand - MVP

> I think it may be time to consider moving to method=post.

Yes!

> Request what? Request.cookies? Don't just use Request("item"). Always
> specify what collection you want to pull from, i.e. querystring, form,
> cookies, servervariables, Clientcertificate

Here's why:
[url]http://www.aspfaq.com/2111[/url]

> Instead of creating a recordset and updating it, why not just execute an
> INSERT command?
>
> sql = "UPDATE [SIMS] SET [syntrack_project]='" &
> Replace(Request.Querystring("project"), "'", "''") & "'"
> connection.Execute sql

Well, an UPDATE statement, and don't forget the WHERE clause. :-)

You could also use a split/join operation to perform a single UPDATE WHERE
IN (a,b,c) statement, instead of performing a loop...

Ray at · Ray at

"Aaron Bertrand - MVP" <aaron@TRASHaspfaq.com> wrote in message
news:uBzYI6%23kDHA.684@TK2MSFTNGP09.phx.gbl...

>
> Well, an UPDATE statement, and don't forget the WHERE clause. :-)

Oops^2. Thanks!

Ray at work

desperate: need help with updating recods

Thread Tools

Display

desperate: need help with updating recods

Similar Questions and Discussions

Updating Updating site map or archive dynamically

Please help, I'm desperate!

I need help, desperate

Updating AI Files causes position to 'bounce' when updating in Quark

Please help, am desperate

Re: desperate: need help with updating recods

Re: desperate: need help with updating recods

Re: desperate: need help with updating recods

Posting Permissions