Fileutils.cp bug?

[Chad Fowler]

I'm experiencing the following behavior in the latest CVS copy of ruby on
both Windows and Linux. I think it's a bug.

[chad@ns1 chad]$ cat test
Goodbye Cruel World!
[chad@ns1 chad]$ ruby -rfileutils -e 'FileUtils.cp("test", "test")'

[chad@ns1 chad]$ cat test
[chad@ns1 chad]$ ls -l test
-rw-rw-r-- 1 chad chad 0 Nov 17 08:35 test
[chad@ns1 chad]$


I would suggest the following small change.

Do others agree that this is a bug?

Thanks,
Chad




Index: fileutils.rb
================================================== =================
RCS file: /src/ruby/lib/fileutils.rb,v
retrieving revision 1.22
diff -u -c -r1.22 fileutils.rb
cvs server: conflicting specifications of output style
*** fileutils.rb 30 Oct 2003 09:36:39 -0000 1.22
--- fileutils.rb 17 Nov 2003 13:11:43 -0000
***************
*** 312,317 ****
--- 312,318 ----
return if options[:noop]

fu_each_src_dest(src, dest) do |s,d|
+ raise ArgumentError, "`#{src}' and `#{dest}' are the same file"
unless (
src != dest)
fu_preserve_attr(options[:preserve], s, d) {
copy_file s, d
}

[Wejn]

Hi,

On Mon, 17 Nov 2003, Chad Fowler wrote:

> I'm experiencing the following behavior in the latest CVS copy of ruby on
> both Windows and Linux. I think it's a bug.
>
> [chad@ns1 chad]$ cat test
> Goodbye Cruel World!
> [chad@ns1 chad]$ ruby -rfileutils -e 'FileUtils.cp("test", "test")'
>
> [chad@ns1 chad]$ cat test
> [chad@ns1 chad]$ ls -l test
> -rw-rw-r-- 1 chad chad 0 Nov 17 08:35 test
> [chad@ns1 chad]$
>
>
> I would suggest the following small change.
>
> Do others agree that this is a bug?

Well, I do think it's a bug ... but the patch is not enough, imho:

(5/wejn/ns) x$ echo "goodbye" > src
(5/wejn/ns) x$ ruby18 -rfileutils -e 'FileUtils.cp("src", "src")'
/usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:315:in `cp': `src' and `src' are the same file (ArgumentError)
from /usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:314:in `fu_each_src_dest'
from /usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:314:in `cp'
from -e:1

... ok ... but:

(5/wejn/ns) x$ ruby18 -rfileutils -e 'FileUtils.cp("src", "./src")'
(5/wejn/ns) x$ ls -l src
-rw-r--r-- 1 wejn wejn 0 Nov 17 15:04 src

... problem :-(

What about comparation of [dev,inode] ?

Sincerely,
Michal
--
# Michal Safranek, email:
a=(("a".."z").to_a+["@","."]);p(("%b"%[0x645bbb83a6a496]
).scan(/...../).map{|x|a[Integer("0b"+x)]}.join.reverse)

[Chad Fowler]

On Mon, 17 Nov 2003, Wejn wrote:

# Hi,
#
# On Mon, 17 Nov 2003, Chad Fowler wrote:
#
# > I'm experiencing the following behavior in the latest CVS copy of ruby on
# > both Windows and Linux. I think it's a bug.
# >
# > [chad@ns1 chad]$ cat test
# > Goodbye Cruel World!
# > [chad@ns1 chad]$ ruby -rfileutils -e 'FileUtils.cp("test", "test")'
# >
# > [chad@ns1 chad]$ cat test
# > [chad@ns1 chad]$ ls -l test
# > -rw-rw-r-- 1 chad chad 0 Nov 17 08:35 test
# > [chad@ns1 chad]$
# >
# >
# > I would suggest the following small change.
# >
# > Do others agree that this is a bug?
#
# Well, I do think it's a bug ... but the patch is not enough, imho:
#
# (5/wejn/ns) x$ echo "goodbye" > src
# (5/wejn/ns) x$ ruby18 -rfileutils -e 'FileUtils.cp("src", "src")'
# /usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:315:in `cp': `src' and `src' are the same file (ArgumentError)
# from /usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:314:in `fu_each_src_dest'
# from /usr/local/ruby-1.8.0/lib/ruby/1.8/fileutils.rb:314:in `cp'
# from -e:1
#
# ... ok ... but:
#
# (5/wejn/ns) x$ ruby18 -rfileutils -e 'FileUtils.cp("src", "./src")'
# (5/wejn/ns) x$ ls -l src
# -rw-r--r-- 1 wejn wejn 0 Nov 17 15:04 src
#
# ... problem :-(
#
# What about comparation of [dev,inode] ?

Good point, Michal. I thik I need some post-RubyConf rest :)

How about (File.expand_path("src") == File.expand_path("dest"))?

[Wejn]

Hi,

> # What about comparation of [dev,inode] ?
>
> Good point, Michal. I thik I need some post-RubyConf rest :)
>
> How about (File.expand_path("src") == File.expand_path("dest"))?

wow ... even better :-) I think it will avoid possible problems
on Win32 (I'm not sure how stat() behaves there regarding to
dev and inode#).

M.
--
# Michal Safranek, email:
a=(("a".."z").to_a+["@","."]);p(("%b"%[0x645bbb83a6a496]
).scan(/...../).map{|x|a[Integer("0b"+x)]}.join.reverse)

[nobu.nokada@softhome.net]

Hi,

At Tue, 18 Nov 2003 00:30:48 +0900,
Zach Dennis wrote:

> Ok I've got the compiling part of Ruby set. Ruby 1.8.1 is up and going.
> However I can't seem to get the Tcltklib to compile. What does the line look
> like when you are using the "--with" statements?

Give them to make as configure_args.

> make configure_args="--with-tcl-dir=I:/source/tcl"

> I've tried things similar to:
>
> bcc32\configure --with...eetc...etc..
>
> when i ran the configure.bat for the ruby compile and i tried running it
> from the tcltklib directory. Any ideas what the command looks like from a
> windows command prompt? It gives me an error upon unknown "--with..."

A batch file is too poor to anlyze them.

--
Nobu Nakada