Help Please - DB Data Repeating

[Jamie Sutherland]

Hi,
Below is the offending code.. When the code runs it displays the data from
the DB multiple times (depending on how many values DS has). How do I stop
it doing this and only show the data once but have the relevant checkboxes
checked.

Thanks
Jamie

DS = "1, 3, 4, 5, 10 , 99"
objRs.Open strSQL, objConn
%>
<table border="1">
<%
objRs.MoveFirst
Do While Not objRs.EOF

arrTmp = Split(DS, ", ")
For i = 0 to UBOUND(arrTmp)

Response.Write ("<tr><td>" & objRs(0) &" - "&objRs(1) &"</td>")
%>
<td align="center">
<input <%If (CStr(arrTmp(i)) = CStr(objRs(0))) Then
Response.Write("checked") : Response.Write("")%> name="Disablility"
type="checkbox" value="<%= objRs(0)%>">
</td></tr>
<%
Next
objRs.Movenext
loop

[Bob Barrows]

Well, it certainly seems to be doing what you told it to do.
The problem is, I don't understand what you want it to do. Cuold you give
use a couple sample rows that would typically be contained in objRs and then
show us what the output should be? (I suspect that the "Response.Write
("<tr><td>" & objRs(0) &" - "&objRs(1) &"</td>")" line should be outside of
(before) the For loop)

Bob Barrows


Jamie Sutherland wrote:

> Hi,
> Below is the offending code.. When the code runs it displays the data
> from the DB multiple times (depending on how many values DS has). How
> do I stop it doing this and only show the data once but have the
> relevant checkboxes checked.
>
> Thanks
> Jamie
>
> DS = "1, 3, 4, 5, 10 , 99"
> objRs.Open strSQL, objConn
> %>
> <table border="1">
> <%
> objRs.MoveFirst
> Do While Not objRs.EOF
>
> arrTmp = Split(DS, ", ")
> For i = 0 to UBOUND(arrTmp)
>
> Response.Write ("<tr><td>" & objRs(0) &" - "&objRs(1) &"</td>")
> %>
> <td align="center">
> <input <%If (CStr(arrTmp(i)) = CStr(objRs(0))) Then
> Response.Write("checked") : Response.Write("")%> name="Disablility"
> type="checkbox" value="<%= objRs(0)%>">
> </td></tr>
> <%
> Next
> objRs.Movenext
> loop

[Ray at]

I assume that you aren't referring to the value and the text of the checkbox
being the same (objRs(0)). So, I'd imagine that your recordset is returning
your data multiple times. See here, [url]http://www.aspfaq.com/5006[/url], and then
post the contents of the strSQL variable.

Ray at work

"Jamie Sutherland" <jamie.sutherland@no.spam.nhcscotland.com> wrote in
message news:%23bkv94EUDHA.1912@TK2MSFTNGP12.phx.gbl...

> Hi,
> Below is the offending code.. When the code runs it displays the data from
> the DB multiple times (depending on how many values DS has). How do I stop
> it doing this and only show the data once but have the relevant checkboxes
> checked.
>
> Thanks
> Jamie
>
> DS = "1, 3, 4, 5, 10 , 99"
> objRs.Open strSQL, objConn
> %>
> <table border="1">
> <%
> objRs.MoveFirst
> Do While Not objRs.EOF
>
> arrTmp = Split(DS, ", ")
> For i = 0 to UBOUND(arrTmp)
>
> Response.Write ("<tr><td>" & objRs(0) &" - "&objRs(1) &"</td>")
> %>
> <td align="center">
> <input <%If (CStr(arrTmp(i)) = CStr(objRs(0))) Then
> Response.Write("checked") : Response.Write("")%> name="Disablility"
> type="checkbox" value="<%= objRs(0)%>">
> </td></tr>
> <%
> Next
> objRs.Movenext
> loop
>
>

[Matt Smith]

Quick point: You set arrTmp inside a While Loop that doesn't change the
value of DS. Do this outside the loop.

Confusion:

>When the code runs it displays the data from the DB multiple times

(depending on how many values DS has)

This doesn't appear to be true. You display data from the db for as many
records as are returned from strSQL.

You appear to be asking:
How do I make one set of check boxes for many records of data. Storing them
back where they came from would prove difficult to impossible so I'm
presuming the results of these check boxes are either for storing elsewhere
or read-only.

Assuming this is what you want I would do the something like this:
Create a 2 dimensional array. Dimension 1 is DS value 1. Dimension 2 is a
boolean representation of whether or not to display checked.
cycle through the records but don't create a check box.
Subloop through the 2dim array. check whether arr(i)=CStr(objRs(0))
If yes then arr(i)(2)=true.
When these loops are done you can create your check boxes:
for each arr(i) make check box. if arr(i)(2) = true then check.

Hope it helps.

Matt Smith

"Jamie Sutherland" <jamie.sutherland@no.spam.nhcscotland.com> wrote in
message news:%23bkv94EUDHA.1912@TK2MSFTNGP12.phx.gbl...

> Hi,
> Below is the offending code.. When the code runs it displays the data from
> the DB multiple times (depending on how many values DS has). How do I stop
> it doing this and only show the data once but have the relevant checkboxes
> checked.
>
> Thanks
> Jamie
>
> DS = "1, 3, 4, 5, 10 , 99"
> objRs.Open strSQL, objConn
> %>
> <table border="1">
> <%
> objRs.MoveFirst
> Do While Not objRs.EOF
>
> arrTmp = Split(DS, ", ")
> For i = 0 to UBOUND(arrTmp)
>
> Response.Write ("<tr><td>" & objRs(0) &" - "&objRs(1) &"</td>")
> %>
> <td align="center">
> <input <%If (CStr(arrTmp(i)) = CStr(objRs(0))) Then
> Response.Write("checked") : Response.Write("")%> name="Disablility"
> type="checkbox" value="<%= objRs(0)%>">
> </td></tr>
> <%
> Next
> objRs.Movenext
> loop
>
>

[Matt Smith]

To define a 2d array with 3 items and a depth of 4:
Dim name(3,4)

To reference individual elements e.g element 2 depth 1:
name(2,1) = "value"

Matt Smith

"Jamie Sutherland" <jamie.sutherland@no.spam.nhcscotland.com> wrote in
message news:uIZ$P2RUDHA.2036@TK2MSFTNGP10.phx.gbl...

> Matt,
> Thanks For The Info. I think that is what I need but have never used 2d
> arrays before and don't know how to do this. Could you please help.
>
> Thanks