I don't get it. What's the difference??

[mmsnork]

Why does #1 below works but not #2? The only difference is that I'm calling
move_uploaded_file() from within a function. Thanks in advance.

Mike

#1:
<?php
$dest = "./images/";
$dest = $dest . $_FILES['userfile']['name'] ;
move_uploaded_file($_FILES['userfile']['tmp_name'], $dest) ;
?>
================================================== =
#2:
<?php
function uploadFile($dest)
{
$dest = "$dest" . $_FILES['userfile']['name'] ;
move_uploaded_file($_FILES['userfile']['name'], $dest);
}

$destDir = "./images/";
uploadFile($destDir) ;
?>

[Andy Hassall]

On Thu, 22 Apr 2004 22:03:58 GMT, Pygar <pygar@spamcop.net> wrote:

>"mmsnork" <nospam9@comcast.net> wrote:
>

>>Why does #1 below works but not #2? The only difference is that I'm calling
>>move_uploaded_file() from within a function. Thanks in advance.
>>
>>Mike
>>
>>#1:
>><?php
>> $dest = "./images/";
>> $dest = $dest . $_FILES['userfile']['name'] ;
>> move_uploaded_file($_FILES['userfile']['tmp_name'], $dest) ;
>>?>
>>================================================ ===

>
>I believe in #2 you need to add one line:
>

>>#2:
>><?php
>>function uploadFile($dest)
>>{

> global $dest;

Actually I don't know off the top of my head what happens now. You have a
local paramter named $dest, and you've just used global $dest. I presume this
brings the global $dest into scope and hides the local parameter? Which
wouldn't be what the OP wants at all in #2, since there isn't a global $dest.

>> $dest = "$dest" . $_FILES['userfile']['name'] ;
>> move_uploaded_file($_FILES['userfile']['name'], $dest);

In #1 you use $_FILES['userfile']['tmp_name'].
In #2 you use $_FILES['userfile']['name'].

move_uploaded_file requires the 'tmp_name', not the 'name'.

>>}
>>
>>$destDir = "./images/";
>>uploadFile($destDir) ;
>>?>
>>

>
>Variable scope is different in PHP than in something like Javascript.
>In order to "pass" a value, you may have to declare it as a global.

The OP was already passing the value as a parameter properly, rather than
"passing" it through a global.

--
Andy Hassall <andy@andyh.co.uk> / Space: disk usage analysis tool
[url]http://www.andyh.co.uk[/url] / [url]http://www.andyhsoftware.co.uk/space[/url]

[mmsnork]

> In #1 you use $_FILES['userfile']['tmp_name'].

> In #2 you use $_FILES['userfile']['name'].

That's it. It was very stupid of me. Thanks Andy.

Mike