Insert Record With cfloop...

[Thomas D]

Can anyone tell me why "#herb_number#" is not evaluated as an existing form
field in the following code?

Thanks,
T

<cfset j = "1">

<cfloop index="HerbInsert" from="1" to="16">

<cfset herb_number = "Form.Herb#j#">
<cfset herb_number_dose = "Form.Herb#j#_dose">

<cfset herb_insert = "#herb_number#">
<cfset herb_insert_dose = "#herb_number_dose#">

<cfif isDefined("Form.herb_insert") and #Form.herb_insert# NEQ "">

<cfquery datasource="#application.DSN#">
INSERT INTO FormulaHerbs (formula_id, herb_id, herb_amount)
VALUES ('#Form.formula_id#', '#herb_insert#', '#insert_dose#')
</cfquery>

</cfif>

<cfset j=j+1>

</cfloop>

[Dan Bracuk]

Probably because this
<cfset herb_number = "Form.Herb#j#">
interprets the Form.Herb part as a string.

Originally posted by: Thomas D
Can anyone tell me why "#herb_number#" is not evaluated as an existing form
field in the following code?

Thanks,
T

<cfset j = "1">

<cfloop index="HerbInsert" from="1" to="16">

<cfset herb_number = "Form.Herb#j#">
<cfset herb_number_dose = "Form.Herb#j#_dose">

<cfset herb_insert = "#herb_number#">
<cfset herb_insert_dose = "#herb_number_dose#">

<cfif isDefined("Form.herb_insert") and #Form.herb_insert# NEQ "">

<cfquery datasource="#application.DSN#">
INSERT INTO FormulaHerbs (formula_id, herb_id, herb_amount)
VALUES ('#Form.formula_id#', '#herb_insert#', '#insert_dose#')
</cfquery>

</cfif>

<cfset j=j+1>

</cfloop>


I kind of understand that I can't get a variable evaluated from within a
variable, so is there another way to do this?

Error:

[Macromedia][SQLServer JDBC Driver][SQLServer]Syntax error converting the
varchar value 'Form.Herb1' to a column of data type int.

[SteveBryant]

You should replace these lines:

<cfset herb_number = "Form.Herb#j#">
<cfset herb_number_dose = "Form.Herb#j#_dose">

with these lines:

<cfset herb_number = Form["Herb#j#"]>
<cfset herb_number_dose = Form["Herb#j#_dose"]>

Your code wasn't evaluating a form variable, but rather returning the name of
the variable that you wanted as the value (so the value would be "Form.Herb1"
instead of the value of the Herb1 form variable.

The code that I have gets the Herb1 key of the form structure (form variables
can be accessed as structures in CFMX and above).

HTH!

Steve

[reenaroy]

replace these lines:

<cfset herb_number = "Form.Herb#j#">
<cfset herb_number_dose = "Form.Herb#j#_dose">

with

<cfset herb_number = "Form.Herb#j#">
<cfset herb_number_dose = evaluate(Form.Herb#j#_dose)>

[Stressed_Simon]

Don't use evaluate() use array notation:-

<cfset herb_number = Form["Herb#j#"]>
<cfset herb_number_dose = Form["Herb#j#_dose"]>

evaluate() has performance issues and in some cases can be a security risk.
99.9% there is a better way of doing things to avoid evaluate(), if you find
yourself in the 0.1% where you need to use it then you are probably something
very unorthodox.

[Thomas D]

Thanks everyone for your wise words... Steve, your code worked flawlessly.

Knowing the Form variables are available in structures is cool...

Again, muchas gracias,

Thomas