Need help to reduce the duplicate php code

[Jason Dumler]

Steven wrote:

> All,
>
> I have these simple php code to check the form input, It will print the
> label red if it is empty and it will save the input if everything about this
> field is right, it will not do anything if it is first visited...
>

<snip>

> Regards,
> -Steven
>
>

The following code should work for an arbitrary number of _POST vars.
It could be modified to check for specifics (SSN is formatted correct,
email addresses are valid emails, etc). If could also be modified to
handle some _POST vars being required, and some not with a big
if/elseif/else statement somewhere in the middle.

<?
// create a list representing our posted variables
$varList = array();
// each variable has a _POST name, a display name and whether it was
saved or not
array_push($varList, array("ssn", "SSN", FALSE));
array_push($varList, array("name", "NAME", FALSE));
// we're gonna use this later, init it here
// (not necessary, I just do this)
$i = 0;
// our default for everything being saved is true
$saved = TRUE;

for ($i=0; $i<count($varList); $i++) {
if ( $_POST ) {
$font_color = "#000000";
if ( empty($_POST[$varList[$i][0]]) ) {
// let the remainder of the script know that
// something wasn't saved
$saved = FALSE;
$font_color = "#ff0000";
} else {
// mark this variable saved in the list
$varList[$i][2] = TRUE;
}
print "<span style='font-size: 9pt; color: " .
$font_color . ";'>" . $varList[$i][1] . "</span>";
print "<br/>\n";
} else {
print "<span style='font-size: 9pt; color: #000000;'>" .
$varList[$i][1] . "</span>";
print "<br/>\n";
}
}

// Now the rest of the script knows whether everything was saved or not,
// and
// if something wasn't saved, it knows which value
?>

Jason

[Steven]

"Jason Dumler" <dumlerjason_bugger_spam@netscape.net> wrote in message
news:5FRMa.563220$vU3.543735@news1.central.cox.net ...

> Steven wrote:

> > All,
> >
> > I have these simple php code to check the form input, It will print the
> > label red if it is empty and it will save the input if everything about

this

> > field is right, it will not do anything if it is first visited...
> >

> <snip>

> > Regards,
> > -Steven
> >
> >

>
> The following code should work for an arbitrary number of _POST vars.
> It could be modified to check for specifics (SSN is formatted correct,
> email addresses are valid emails, etc). If could also be modified to
> handle some _POST vars being required, and some not with a big
> if/elseif/else statement somewhere in the middle.
>
> <?
> // create a list representing our posted variables
> $varList = array();
> // each variable has a _POST name, a display name and whether it was
> saved or not
> array_push($varList, array("ssn", "SSN", FALSE));
> array_push($varList, array("name", "NAME", FALSE));
> // we're gonna use this later, init it here
> // (not necessary, I just do this)
> $i = 0;
> // our default for everything being saved is true
> $saved = TRUE;
>
> for ($i=0; $i<count($varList); $i++) {
> if ( $_POST ) {
> $font_color = "#000000";
> if ( empty($_POST[$varList[$i][0]]) ) {
> // let the remainder of the script know that
> // something wasn't saved
> $saved = FALSE;
> $font_color = "#ff0000";
> } else {
> // mark this variable saved in the list
> $varList[$i][2] = TRUE;
> }
> print "<span style='font-size: 9pt; color: " .
> $font_color . ";'>" . $varList[$i][1] . "</span>";
> print "<br/>\n";
> } else {
> print "<span style='font-size: 9pt; color: #000000;'>" .
> $varList[$i][1] . "</span>";
> print "<br/>\n";
> }
> }
>
> // Now the rest of the script knows whether everything was saved or not,
> // and
> // if something wasn't saved, it knows which value
> ?>
>
> Jason
>

Thanks a lot and I will try it out...

Regards,
-Steven

[lawrence]

Jason Dumler <dumlerjason_bugger_spam@netscape.net> wrote in message news:<5FRMa.563220$vU3.543735@news1.central.cox.ne t>...

> Steven wrote:

> > All,
> >
> > I have these simple php code to check the form input, It will print the
> > label red if it is empty and it will save the input if everything about this
> > field is right, it will not do anything if it is first visited...

If you're sure the form input will be the only input in $_POST (and
you're sure your code will always be run on machines that use PHP 4.1
or newer, something I that has never been true for me), then you
should be able to attack your problem in a loop:

while (list($key, $val) = each($_POST) ) {
if ($val) {
// code for filled in input
} else {
// code for input left empty
}

}

[Steven]

"Steven" <xueming@comcast.net> wrote in message
news:sk5Na.30933$926.1937@sccrnsc03...

>
> "lawrence" <lkrubner@geocities.com> wrote in message
> news:da7e68e8.0307031223.2b4967b8@posting.google.c om...

> > Jason Dumler <dumlerjason_bugger_spam@netscape.net> wrote in message

> news:<5FRMa.563220$vU3.543735@news1.central.cox.ne t>...

> > > Steven wrote:
> > > > All,
> > > >
> > > > I have these simple php code to check the form input, It will print

> the

> > > > label red if it is empty and it will save the input if everything

> about this

> > > > field is right, it will not do anything if it is first visited...

> >
> > If you're sure the form input will be the only input in $_POST (and
> > you're sure your code will always be run on machines that use PHP 4.1
> > or newer, something I that has never been true for me), then you
> > should be able to attack your problem in a loop:
> >
> > while (list($key, $val) = each($_POST) ) {
> > if ($val) {
> > // code for filled in input
> > } else {
> > // code for input left empty
> > }
> >
> > }

>
> Thanks a lot.
>
> Would it be possible to write a function for this using $_POST and an

array

> (have name and name tag) as input?
>
> In that case, I would not need anything else for my form.
>
> Is it possible ?
>
> I will try it tonight ...
>
> -Regards,
> Steven
>
>

Yes, it is working with a function also. Thanks!!

-Steven

[lawrence]

"Steven" <xueming@comcast.net> wrote in message news:<MrbNa.100357

> > > If you're sure the form input will be the only input in $_POST (and
> > > you're sure your code will always be run on machines that use PHP 4.1
> > > or newer, something I that has never been true for me), then you
> > > should be able to attack your problem in a loop:
> > >
> > > while (list($key, $val) = each($_POST) ) {
> > > if ($val) {
> > > // code for filled in input
> > > } else {

> // code for input left empty

> > > }

>

> > > }

> >
> > Thanks a lot.
> >
> > Would it be possible to write a function for this using $_POST and an

> array

> > (have name and name tag) as input?
> >
> > In that case, I would not need anything else for my form.
> >
> > Is it possible ?

Your welcome. As I mentioned before, you'll only run into problems if
you ever try to run your code on a machine running PHP pre to version
4.1.