recordset while loop problem

[Dyslexic]

Hi all,

I'm trying to write a bit of ASP code topopulate a select box, the data that
I'm using to fill the select box is in a recordset - which also contains
data for other selectboxes. - hence the 'manufacturer' feild getting
compared. The code I'm using is this -

<select name="select" size="1">
<option value="Select a Model!" selected="selected">Select a
Model</option>
<option value="Select a Model">Show All</option>
<%While ((NOT pullallmanhorizmodels.EOF) AND
(allsunbedman.Fields.Item("manufacturer").Value =
pullallmanhorizmodels.Fields.Item("manufacturer"). Value))%>
<option
value="<%=pullallmanhorizmodels.Fields.Item("model ")%>"><%=pullallmanhorizmo
dels.Fields.Item("model")%></option>
<% pullallmanhorizmodels.MoveNext
wend%>
</select>

It 'seem's' to be working until it gets to the last record, where it causes
the computer to hang?

Cheers.

[J. Baute]

without really answering to your question,
why not change your SQL statement usign a JOIN to avoid having to use 2
recordset, while it's probably possible to get all the data in the format
you need in a single recordset, and thus simplifying things a lot

"Dyslexic" <I'hate-@ll&^SPAMH@r^esters.com> wrote in message
news:4wAfc.14228$Z07.7167@news-binary.blueyonder.co.uk...

> Hi all,
>
> I'm trying to write a bit of ASP code topopulate a select box, the data

that

> I'm using to fill the select box is in a recordset - which also contains
> data for other selectboxes. - hence the 'manufacturer' feild getting
> compared. The code I'm using is this -
>
> <select name="select" size="1">
> <option value="Select a Model!" selected="selected">Select a
> Model</option>
> <option value="Select a Model">Show All</option>
> <%While ((NOT pullallmanhorizmodels.EOF) AND
> (allsunbedman.Fields.Item("manufacturer").Value =
> pullallmanhorizmodels.Fields.Item("manufacturer"). Value))%>
> <option
>

value="<%=pullallmanhorizmodels.Fields.Item("model ")%>"><%=pullallmanhorizmo

> dels.Fields.Item("model")%></option>
> <% pullallmanhorizmodels.MoveNext
> wend%>
> </select>
>
> It 'seem's' to be working until it gets to the last record, where it

causes

> the computer to hang?
>
> Cheers.
>
>

[Dyslexic]

Hi Mate,
Thanks for your response, regarding your suggestion of using a JOIN
statement to get all this info in the one recordset - As you can see from my
code I currently have two recordsets, I did this because the first recordset
is looped round a Horiz/Vertical looper, the second recordset provides the
options for the selectbox (for each of the items in the first loop) - I did
try using a JOIN statement but had problems getting the JOIN statement to
work with my crappy access odbc/db (newbie alert here) - even if I get the
join statement to work I'll still be left with the problem of selecting the
correct/relevant items for each selectbox.(the data for many different
selectbox's is returned within the pullallmanhorizmodels recordset.

I'm sure I'm doing something silly here - could it possibly be to do with
comparing the two "manufacturer" fields once it reaches the last record
(n.b- even with a join statement I would need a condition like this to
separate the contents for each selkectbox). (As I said before - it works
fine until it reaches the last "pullallmanhorizmodels" record then just
seems to hang the web page (I can publish this page if it would provide any
useful info) there are no error messages or anything the server just stop's
serving the rest of the page.

Again - Cheers,

Dyslexic.


"J. Baute" <WUPYRDEDAWJD@spammotel.com> wrote in message
news:407f8374$0$992$a0ced6e1@news.skynet.be...

> without really answering to your question,
> why not change your SQL statement usign a JOIN to avoid having to use 2
> recordset, while it's probably possible to get all the data in the format
> you need in a single recordset, and thus simplifying things a lot
>
> "Dyslexic" <I'hate-@ll&^SPAMH@r^esters.com> wrote in message
> news:4wAfc.14228$Z07.7167@news-binary.blueyonder.co.uk...

> > Hi all,
> >
> > I'm trying to write a bit of ASP code topopulate a select box, the data

> that

> > I'm using to fill the select box is in a recordset - which also

contains

> > data for other selectboxes. - hence the 'manufacturer' feild getting
> > compared. The code I'm using is this -
> >
> > <select name="select" size="1">
> > <option value="Select a Model!" selected="selected">Select a
> > Model</option>
> > <option value="Select a Model">Show All</option>
> > <%While ((NOT pullallmanhorizmodels.EOF) AND
> > (allsunbedman.Fields.Item("manufacturer").Value =
> > pullallmanhorizmodels.Fields.Item("manufacturer"). Value))%>
> > <option
> >

>

value="<%=pullallmanhorizmodels.Fields.Item("model ")%>"><%=pullallmanhorizmo

> > dels.Fields.Item("model")%></option>
> > <% pullallmanhorizmodels.MoveNext
> > wend%>
> > </select>
> >
> > It 'seem's' to be working until it gets to the last record, where it

> causes

> > the computer to hang?
> >
> > Cheers.
> >
> >

>
>

[roger]

"Dyslexic" <qwert@@@@.com>

> I'm sure I'm doing something silly here - could it possibly be to do with
> comparing the two "manufacturer" fields once it reaches the last record

Probably, but if that is the case I'm surprised that you don't get an error.

Does this work ---

do until pullallmanhorizmodels.EOF

if pullallmanhorizmodels("manufacturer") = allsunbedman("manufacturer")
then
%><option value= ---etc--- </option><%
end if

pullallmanhorizmodels.MoveNext

loop


--
roger

[Dyslexic]

"roger" <mothland@btopenworld.com> wrote in message
news:c5pm5m$f2k$1@hercules.btinternet.com...

> "Dyslexic" <qwert@@@@.com>
>

> > I'm sure I'm doing something silly here - could it possibly be to do

with

> > comparing the two "manufacturer" fields once it reaches the last record

>
> Probably, but if that is the case I'm surprised that you don't get an

error.

>
> Does this work ---
>
> do until pullallmanhorizmodels.EOF
>
> if pullallmanhorizmodels("manufacturer") =

allsunbedman("manufacturer")

> then
> %><option value= ---etc--- </option><%
> end if
>
> pullallmanhorizmodels.MoveNext
>
> loop

END SNIP

Hi Rodger,

Thanks for you help, I've tried many different ways to get the same logic as
what my original 'should' do but am failing horribly. I have tried and got
working your code (I used a 'while' outer loop, instead of your 'do until'
loop but it was essentially the same).

This code works perfectly within its own rights but does not give my desired
results because the 'do until' loop takes the 'pullallmanhorizmodels'
recordset right to it's end on its first go (remember this is all contained
within a horiz/vertical looper) so when it gets past filling the first
selectbox the conditions are never correct to allow it to fill the rest of
the select boxes. Is there a method of returning the recordset to its start
position? If I were to reset the record set to its start then it should work
correctly?

N.b I played with my original version and discovered that if I put a 'duff'
record at the end of the recordset so that 'I know' that the LAST items to
be tested will produce a false (and not run the code) it works as expected
WTF?

I'm losing it now and failing horribly to explain have a look at a test page
(n.b please no comments on anything other than this problem (this is still a
work in progress) (unless you know how to fix the menu to stop it going
under some of the other page items

[url]http://www.dyslexicfingars.net/ultratek/sunbedsall.asp[/url]

n.b. This page (currently) has the version with the 'IF' statement in it and
works - but only for the first selectbox.

Cheers

Dyslexic

[roger]

"Dyslexic" wrote

> This code works perfectly within its own rights but does not give my

desired

> results because the 'do until' loop takes the 'pullallmanhorizmodels'
> recordset right to it's end on its first go (remember this is all

contained

> within a horiz/vertical looper) so when it gets past filling the first
> selectbox the conditions are never correct to allow it to fill the rest of
> the select boxes. Is there a method of returning the recordset to its

start

> position? If I were to reset the record set to its start then it should

work

> correctly?

Actually, that was why I used 'do ... loop' -
because you can use "exit do". I don't think
you can do that with "while".

do until pullallmanhorizmodels.EOF
if pullallmanhorizmodels("manufacturer")
= allsunbedman("manufacturer") then
%><option value= ---etc--- </option><%
else
exit do
end if
pullallmanhorizmodels.MoveNext
loop

> N.b I played with my original version and discovered that if I put a

'duff'

> record at the end of the recordset so that 'I know' that the LAST items to
> be tested will produce a false (and not run the code) it works as expected
> WTF?

If you have an expression like -

True and False and True and True

All languages have rules about whether to evaluate the whole expression
or just until the first 'False'.

I can't remember what VB does (or even what this is called),
but I guess it does the whole line.

So with -

NOT pullallmanhorizmodels.EOF AND pullallmanhorizmodels("manufacturer") =
allsunbedman("manufacturer")


The EOF has been reached but it still tries to evaluate
the next part of the expression.

If you run your original code again, and then do "view source"
on the web page, perhaps the error message is at the bottom
of the page.

> I'm losing it now and failing horribly to explain have a look at a test

page

> (n.b please no comments on anything other than this problem (this is still

a

> work in progress) (unless you know how to fix the menu to stop it going
> under some of the other page items

I don't think you can hide select boxes under other things.

AFAIK the only way is to use client side script to determine
when they are partially covered, and then hide the whole box.

It's messy, and it looks almost as bad.

You'll save yourself a lot brain ache if you just rearrange the page.

--
roger