Saving entire file

[MJS]

Can someone help me with the following code.
It just saves/prints the line in which 'hello' occured.
why doesn't it save the entire file i.e why don't i get the entire
content of file1 in file2 ?

open(FILEREAD, "file1") or die "Can't open file1: $!\n";

while(<FILEREAD>) {
#searching the string
if(/hello/) {

open(FILEWRITE, ">file2") or die "Can't open file2: $!\n";
select FILEWRITE; # this is not needed.
print FILEWRITE ;
close(FILEWRITE);
}
}
close(FILEREAD);

[Mike Flannigan]

Gunnar Hjalmarsson wrote:

> MJS wrote:

> > Can someone help me with the following code.
> > It just saves/prints the line in which 'hello' occured.
> > why doesn't it save the entire file i.e why don't i get the entire
> > content of file1 in file2 ?

>
> Because you didn't tell Perl to do that. :)
>

> > print FILEWRITE ;

>
> That prints the content of $_ to FILEWRITE. Please study
> [url]http://www.perldoc.com/perl5.8.0/pod/perlsyn.html[/url]
>
> If you replace that line with:
>
> seek FILEREAD, 0, 0;
> print FILEWRITE join '', <FILEREAD>;
>
> the script should do what you want. You may want to reed about 'seek'
> and 'join' at [url]http://www.perldoc.com/perl5.8.0/pod/perlfunc.html[/url]
>
> There are (of course) other available solutions...

If I'm not mistaken, you also need to open the filewrite for
appending.

open(FILEWRITE, ">>file2") or die "Can't open file2: $!\n";
^
^

[Gunnar Hjalmarsson]

Mike Flannigan wrote:

> Gunnar Hjalmarsson wrote:

>>MJS wrote:
>>

>>>Can someone help me with the following code.
>>>It just saves/prints the line in which 'hello' occured.
>>>why doesn't it save the entire file i.e why don't i get the entire
>>>content of file1 in file2 ?

>>
>>Because you didn't tell Perl to do that. :)
>>

>>>print FILEWRITE ;

>>
>>That prints the content of $_ to FILEWRITE. Please study
>>[url]http://www.perldoc.com/perl5.8.0/pod/perlsyn.html[/url]
>>
>>If you replace that line with:
>>
>> seek FILEREAD, 0, 0;
>> print FILEWRITE join '', <FILEREAD>;
>>
>>the script should do what you want. You may want to reed about 'seek'
>>and 'join' at [url]http://www.perldoc.com/perl5.8.0/pod/perlfunc.html[/url]
>>
>>There are (of course) other available solutions...

>
> If I'm not mistaken, you also need to open the filewrite for
> appending.
>
> open(FILEWRITE, ">>file2") or die "Can't open file2: $!\n";

Only if appending is what OP wants to do. Note that it was opened for
writing.

But I'd like to correct my solution in another respect. The 'join'
function is redundant, and the following should do it:

seek FILEREAD, 0, 0;
print FILEWRITE <FILEREAD>;

--
Gunnar Hjalmarsson
Email: [url]http://www.gunnar.cc/cgi-bin/contact.pl[/url]

[ctcgag@hotmail.com]

[email]tabletdesktop@yahoo.com[/email] (MJS) wrote:

> Can someone help me with the following code.
> It just saves/prints the line in which 'hello' occured.
> why doesn't it save the entire file i.e why don't i get the entire
> content of file1 in file2 ?
>
> open(FILEREAD, "file1") or die "Can't open file1: $!\n";
>
> while(<FILEREAD>) {
> #searching the string
> if(/hello/) {
>
> open(FILEWRITE, ">file2") or die "Can't open file2: $!\n";
> select FILEWRITE; # this is not needed.
> print FILEWRITE ;
> close(FILEWRITE);
> }
> }
> close(FILEREAD);

For every line in file1 containing hello, you write that one line
to file2, overwriting whatever file2 may have existed previously.
Thus, the eventual file2 is left with the final hello containing
line in file1.

--
-------------------- [url]http://NewsReader.Com/[/url] --------------------
Usenet Newsgroup Service New Rate! $9.95/Month 50GB