where should you start to look if unchanged code starts to have bugs?

[Tom Thackrey]

On 12-Jul-2003, [email]lkrubner@geocities.com[/email] (lawrence) wrote:

> Dealing with strange problems today. Below is some code that hasn't
> been changed in about 6 months. It calls the function wrapInDiv, which
> hasn't been changed in at least a year. Now I'm suddenly getting the
> error "Fatal error: Maximum execution time of 30 seconds exceeded" and
> it indicates the last line of this function. Since that can't be true,
> what other kinds of problems should I be looking for?
>
> function formLink($introText, $choiceMade, $hiddenName2="",
> $hidden2="", $hiddenName3="", $hidden3="") {
> $link = "<a class=\"formLink\" href=\"";
> $link .= $self;
> $link .= "?choiceMade=";
> $link .= $choiceMade;
> if ($hiddenName2 != "") $link .= "&".$hiddenName2."=".$hidden2;
> if ($hiddenName3 != "") $link .= "&".$hiddenName3."=".$hidden3;
> $link .= "\">";
> $link .= $introText;
> $link .= "</a>\n";
> wrapInDiv($link, "mcFormBlock");
> }

One problem is $self is undefined. If you're sure wrapInDiv isn't the
problem, remove it and see if you timeout.

--
Tom Thackrey
[url]www.creative-light.com[/url]

[Nikolai Chuvakhin]

[email]lkrubner@geocities.com[/email] (lawrence) wrote in message
news:<da7e68e8.0307120904.1f44a4a0@posting.google. com>...

>
> Dealing with strange problems today. Below is some code that hasn't
> been changed in about 6 months. It calls the function wrapInDiv, which
> hasn't been changed in at least a year. Now I'm suddenly getting the
> error "Fatal error: Maximum execution time of 30 seconds exceeded" and
> it indicates the last line of this function. Since that can't be true,
> what other kinds of problems should I be looking for?

Changes in server setup, in particular, register_globals and
error reporting levels.

Cheers,
NC

[lawrence]

Thanks both for the replies. In the end, I think most of the problem
was that I had, unthinkingly, passed my config array, holding all
config data, by reference to all my (new, untested) 00 classes.
Debugging when passing variables by reference required a new mindset
for me.